[AIST-QA] Fix memory leak issue in end_effectors_widget. #1829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gets - Correct the indication by the static analysis tool.
max-krichenbauer
changed the title
rhaschke
approved these changes
Jan 9, 2020
|
Thanks for your analysis effort and for filing this bug fix. |
max-krichenbauer
deleted the
feature/analysis_tool/melodic/error/Memory_Leak/moveit_setup_assistant
branch
rhaschke
pushed a commit
to ubi-agni/moveit
that referenced
this pull request
Jan 9, 2020
…gets (moveit#1829) - Correct the indication by the static analysis tool. Co-authored-by: Kazuki-Hazama <57083115+KazukiHazama@users.noreply.github.com>
rhaschke
pushed a commit
to ubi-agni/moveit
that referenced
this pull request
Jan 9, 2020
…gets (moveit#1829) - Correct the indication by the static analysis tool. Co-authored-by: Kazuki-Hazama <57083115+KazukiHazama@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In
end_effectors_widget.cpp,searched_datavariable is not deleted which causes a memory leak.This issue may have been overlooked because the similar bugs were fixed in other source files (
virtual_joints_widget.cppandrobot_poses_widget.cpp).This fix adds
delete searched_data;to the functiondoneEditing().This contribution is made by AIST ( https://www.aist.go.jp ) based on static code analysis with klocwork (Perforce Software).
Checklist