Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo elseif() to else() #1857

Merged
merged 1 commit into from
Jan 23, 2020
Merged

Fix typo elseif() to else() #1857

merged 1 commit into from
Jan 23, 2020

Conversation

lucarinelli
Copy link
Contributor

Description

I think this was a typo. In my tests libboost_python is being found and linked also with Boost 1.67.0 with this change. Related to #1850

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

I think this was a typo. In my tests libboost_python is being found and linked also with Boost 1.67.0 with this change.
@welcome
Copy link

welcome bot commented Jan 23, 2020

Thanks for helping in improving MoveIt and open source robotics!

Copy link
Contributor

@rhaschke rhaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thanks.

@rhaschke rhaschke merged commit e582953 into moveit:master Jan 23, 2020
@welcome
Copy link

welcome bot commented Jan 23, 2020

Congrats on getting your first MoveIt pull request merged and improving open source robotics!

v4hn pushed a commit to v4hn/moveit that referenced this pull request Mar 30, 2020
v4hn pushed a commit to v4hn/moveit that referenced this pull request Mar 31, 2020
v4hn pushed a commit to v4hn/moveit that referenced this pull request Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants