MP display: change internal shortcut Ctrl+R to Ctrl+I #1967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ctrl+R is used by RViz to rename displays. Overlaying the sequence semi-breaks the behavior and the rename button gets selected, but not pressed. This is an internal shortcut used in case the interactive markers of the display fail to update correctly. This is seldomly (never?) used, so remapping does not hurt anyone. To the best of my knowledge Ctrl+I is not used in standard RViz.
rhaschke
approved these changes
Mar 25, 2020
It did not harm up to now, so no reason to drop it I guess. |
tylerjw
pushed a commit
to PickNikRobotics/moveit
that referenced
this pull request
Mar 28, 2020
Ctrl+R is used by RViz to rename displays. Overlaying the sequence semi-breaks the behavior and the rename button gets selected, but not pressed. This is an internal shortcut used in case the interactive markers of the display fail to update correctly. This is seldomly (never?) used, so remapping does not hurt anyone. To the best of my knowledge Ctrl+I is not used in standard RViz.
v4hn
added a commit
to v4hn/moveit
that referenced
this pull request
Mar 30, 2020
Ctrl+R is used by RViz to rename displays. Overlaying the sequence semi-breaks the behavior and the rename button gets selected, but not pressed. This is an internal shortcut used in case the interactive markers of the display fail to update correctly. This is seldomly (never?) used, so remapping does not hurt anyone. To the best of my knowledge Ctrl+I is not used in standard RViz.
v4hn
added a commit
to v4hn/moveit
that referenced
this pull request
Mar 31, 2020
Ctrl+R is used by RViz to rename displays. Overlaying the sequence semi-breaks the behavior and the rename button gets selected, but not pressed. This is an internal shortcut used in case the interactive markers of the display fail to update correctly. This is seldomly (never?) used, so remapping does not hurt anyone. To the best of my knowledge Ctrl+I is not used in standard RViz.
v4hn
added a commit
to v4hn/moveit
that referenced
this pull request
Mar 31, 2020
Ctrl+R is used by RViz to rename displays. Overlaying the sequence semi-breaks the behavior and the rename button gets selected, but not pressed. This is an internal shortcut used in case the interactive markers of the display fail to update correctly. This is seldomly (never?) used, so remapping does not hurt anyone. To the best of my knowledge Ctrl+I is not used in standard RViz.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ctrl+R is used by RViz to rename displays.
Overlaying the sequence semi-breaks the behavior
and the rename button gets selected, but not pressed.
This is an internal shortcut used in case the interactive markers
of the display fail to update correctly. This is seldomly (never?)
used, so remapping does not hurt anyone.
To the best of my knowledge Ctrl+I is not used in standard RViz.