Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jog_arm] Add a binary collision check #1978

Merged
merged 3 commits into from
Mar 26, 2020
Merged

[jog_arm] Add a binary collision check #1978

merged 3 commits into from
Mar 26, 2020

Conversation

AndyZe
Copy link
Member

@AndyZe AndyZe commented Mar 26, 2020

Add a binary collision check to the distance-based collision check. This helps with edge cases like starting inside another body and reducing overall flakiness.

Also, delete the parameter hard_stop_singularity_threshold which hasn't been used in some time.

Copy link
Member

@henningkayser henningkayser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for preparing this

@henningkayser henningkayser merged commit 8946d26 into moveit:master Mar 26, 2020
tylerjw pushed a commit to PickNikRobotics/moveit that referenced this pull request Mar 28, 2020
@tylerjw tylerjw mentioned this pull request May 8, 2020
20 tasks
tylerjw pushed a commit to PickNikRobotics/moveit that referenced this pull request May 12, 2020
tylerjw pushed a commit to PickNikRobotics/moveit that referenced this pull request May 12, 2020
tylerjw pushed a commit to PickNikRobotics/moveit that referenced this pull request May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants