Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move constraint representation dox to moveit_tutorials #2147

Merged
merged 1 commit into from
Aug 19, 2020

Conversation

davetcoleman
Copy link
Member

Copy link
Contributor

@v4hn v4hn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not even aware this documentation existed!

@codecov
Copy link

codecov bot commented Jun 10, 2020

Codecov Report

Merging #2147 into master will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2147      +/-   ##
==========================================
- Coverage   57.82%   57.72%   -0.10%     
==========================================
  Files         328      328              
  Lines       25700    25735      +35     
==========================================
- Hits        14860    14855       -5     
- Misses      10840    10880      +40     
Impacted Files Coverage Δ
.../ompl_interface/src/detail/constrained_sampler.cpp 46.15% <0.00%> (-17.95%) ⬇️
...ntal/moveit_jog_arm/src/collision_check_thread.cpp 80.59% <0.00%> (-9.97%) ⬇️
...ove_group_interface/src/wrap_python_move_group.cpp 39.87% <0.00%> (-3.17%) ⬇️
...veit_experimental/moveit_jog_arm/src/jog_calcs.cpp 70.93% <0.00%> (-2.05%) ⬇️
...ipulation/pick_place/src/manipulation_pipeline.cpp 76.41% <0.00%> (-0.95%) ⬇️
...rimental/moveit_jog_arm/src/jog_interface_base.cpp 72.79% <0.00%> (-0.23%) ⬇️
.../move_group_interface/src/move_group_interface.cpp 47.86% <0.00%> (-0.22%) ⬇️
...veit_jog_arm/include/moveit_jog_arm/jog_arm_data.h 100.00% <0.00%> (ø)
...rm/include/moveit_jog_arm/collision_check_thread.h 100.00% <0.00%> (ø)
...meterization/work_space/pose_model_state_space.cpp 82.99% <0.00%> (+0.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bdce08...71385aa. Read the comment docs.

@mamoll
Copy link
Contributor

mamoll commented Jun 10, 2020

Of all the images you deleted, only one is used in moveit/moveit_tutorials#501. The other images were unused, but are they also useless for the tutorial? When the tutorial stub gets fleshed out, perhaps these images could still be useful?

@davetcoleman
Copy link
Member Author

We haven't used the images in ~10 years, so i don't think they are that important

@davetcoleman davetcoleman merged commit a1ebe89 into moveit:master Aug 19, 2020
@tylerjw tylerjw mentioned this pull request Oct 23, 2020
57 tasks
tylerjw pushed a commit to tylerjw/moveit that referenced this pull request Oct 23, 2020
tylerjw pushed a commit to tylerjw/moveit that referenced this pull request Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants