-
Notifications
You must be signed in to change notification settings - Fork 937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jog_arm] fix access past end of array bug #2155
Merged
tylerjw
merged 2 commits into
moveit:master
from
PickNikRobotics:p/tylerjw/jog_arm_array
Jun 19, 2020
Merged
[jog_arm] fix access past end of array bug #2155
tylerjw
merged 2 commits into
moveit:master
from
PickNikRobotics:p/tylerjw/jog_arm_array
Jun 19, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IMO there's no reason not to add a check like this 👍 |
AndyZe
approved these changes
Jun 19, 2020
henningkayser
approved these changes
Jun 19, 2020
Codecov Report
@@ Coverage Diff @@
## master #2155 +/- ##
==========================================
- Coverage 57.94% 57.90% -0.04%
==========================================
Files 327 327
Lines 25640 25640
==========================================
- Hits 14857 14848 -9
- Misses 10783 10792 +9
Continue to review full report at Codecov.
|
6 tasks
tylerjw
added a commit
to PickNikRobotics/moveit
that referenced
this pull request
Jun 24, 2020
* [jog_arm] fix access past end of array bug
tylerjw
added a commit
to PickNikRobotics/moveit
that referenced
this pull request
Jun 24, 2020
* [jog_arm] fix access past end of array bug
tylerjw
added a commit
to PickNikRobotics/moveit
that referenced
this pull request
Jun 24, 2020
* [jog_arm] fix access past end of array bug
tylerjw
added a commit
to PickNikRobotics/moveit
that referenced
this pull request
Jun 24, 2020
* [jog_arm] fix access past end of array bug
tylerjw
added a commit
to PickNikRobotics/moveit
that referenced
this pull request
Jun 24, 2020
* [jog_arm] fix access past end of array bug
tylerjw
added a commit
to PickNikRobotics/moveit
that referenced
this pull request
Jun 29, 2020
* [jog_arm] fix access past end of array bug
tylerjw
added a commit
to PickNikRobotics/moveit
that referenced
this pull request
Jul 1, 2020
* [jog_arm] fix access past end of array bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Manually tracing the code I'm not sure how this is happening but it is and this causes odd behavior (sending trajectory data from seemingly random data).