Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jog_arm] fix access past end of array bug #2155

Merged
merged 2 commits into from
Jun 19, 2020

Conversation

tylerjw
Copy link
Member

@tylerjw tylerjw commented Jun 19, 2020

Description

Manually tracing the code I'm not sure how this is happening but it is and this causes odd behavior (sending trajectory data from seemingly random data).

@tylerjw tylerjw requested a review from AndyZe June 19, 2020 13:56
@AndyZe
Copy link
Member

AndyZe commented Jun 19, 2020

IMO there's no reason not to add a check like this 👍

@codecov
Copy link

codecov bot commented Jun 19, 2020

Codecov Report

Merging #2155 into master will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2155      +/-   ##
==========================================
- Coverage   57.94%   57.90%   -0.04%     
==========================================
  Files         327      327              
  Lines       25640    25640              
==========================================
- Hits        14857    14848       -9     
- Misses      10783    10792       +9     
Impacted Files Coverage Δ
...veit_experimental/moveit_jog_arm/src/jog_calcs.cpp 71.10% <0.00%> (-0.26%) ⬇️
.../ompl_interface/src/detail/constrained_sampler.cpp 46.15% <0.00%> (-17.95%) ⬇️
...ove_group_interface/src/wrap_python_move_group.cpp 39.87% <0.00%> (-3.17%) ⬇️
...anning_scene_monitor/src/current_state_monitor.cpp 51.28% <0.00%> (-1.54%) ⬇️
.../move_group_interface/src/move_group_interface.cpp 47.86% <0.00%> (-0.22%) ⬇️
...meterization/work_space/pose_model_state_space.cpp 82.99% <0.00%> (+0.68%) ⬆️
...ipulation/pick_place/src/manipulation_pipeline.cpp 77.35% <0.00%> (+0.94%) ⬆️
moveit_core/robot_model/src/joint_model_group.cpp 61.81% <0.00%> (+2.42%) ⬆️
...e/src/parameterization/model_based_state_space.cpp 73.10% <0.00%> (+2.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a03b10d...fc3f838. Read the comment docs.

@tylerjw tylerjw merged commit 9e4a164 into moveit:master Jun 19, 2020
@tylerjw tylerjw deleted the p/tylerjw/jog_arm_array branch June 19, 2020 14:44
tylerjw added a commit to PickNikRobotics/moveit that referenced this pull request Jun 24, 2020
* [jog_arm] fix access past end of array bug
tylerjw added a commit to PickNikRobotics/moveit that referenced this pull request Jun 24, 2020
* [jog_arm] fix access past end of array bug
tylerjw added a commit to PickNikRobotics/moveit that referenced this pull request Jun 24, 2020
* [jog_arm] fix access past end of array bug
tylerjw added a commit to PickNikRobotics/moveit that referenced this pull request Jun 24, 2020
* [jog_arm] fix access past end of array bug
tylerjw added a commit to PickNikRobotics/moveit that referenced this pull request Jun 24, 2020
* [jog_arm] fix access past end of array bug
tylerjw added a commit to PickNikRobotics/moveit that referenced this pull request Jun 29, 2020
* [jog_arm] fix access past end of array bug
tylerjw added a commit to PickNikRobotics/moveit that referenced this pull request Jul 1, 2020
* [jog_arm] fix access past end of array bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants