Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterize input trajectory density of Time Optimal trajectory generation #2185

Merged
merged 1 commit into from
Jul 3, 2020
Merged

Parameterize input trajectory density of Time Optimal trajectory generation #2185

merged 1 commit into from
Jul 3, 2020

Conversation

pbeeson
Copy link
Contributor

@pbeeson pbeeson commented Jul 3, 2020

Description

MoveIt wrapper to Time Optimal Trajectory Generation downsamples trajectory, but its hard coded to keep waypoints with at least 0.001 radians of motion on a joint. For very long and/or dense input trajectories, the downsampled trajectory is still way too large for the iterative optimization algorithm to finish in reasonable time. I was seeing 3000 point trajectory taking ~15 seconds. This fix allows the user to set this downsampling density in minimum radians of motion between two waypoints to something else (presumably higher like 0.5 degrees [0.00875 radians]) in order to drastically improve the speed of this algorithm.

Checklist

  • [ x ] Required by CI: Code is auto formatted using clang-format

…ectory, but its hard coded to keep waypoints with at least 0.001 radians of motion on a joint. For very long and/or dense input trajectories, the downsampled trajectory is still way too large for the iterative optimization algorithm to finish in reasonable time. I was seeing 3000 point trajectory taking ~15 seconds. This fix allows the user to set this downsampling density in minimum radians of motion between two waypoints to something else (presumably higher like 0.5 degrees [0.00875 radians]) in order to drastically improve the speed of this algorithm.
@pbeeson pbeeson requested a review from mlautman as a code owner July 3, 2020 02:03
Copy link
Contributor

@v4hn v4hn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging as straight-forward extension.

@v4hn v4hn merged commit a15551f into moveit:master Jul 3, 2020
@welcome
Copy link

welcome bot commented Jul 3, 2020

Congrats on getting your first MoveIt pull request merged and improving open source robotics!

@v4hn
Copy link
Contributor

v4hn commented Jul 3, 2020

Thanks @pbeeson . I was annoyed by that hardcoded value as well when I looked through this, but did not have a reason to make it configurable.

v4hn pushed a commit to v4hn/moveit that referenced this pull request Jul 3, 2020
…ration (moveit#2185)

MoveIt wrapper to Time Optimal Trajectory Generation downsamples trajectory, but its hard coded to keep waypoints with at least 0.001 radians of motion on a joint.  For very long and/or dense input trajectories, the downsampled trajectory is still way too large for the iterative optimization algorithm to finish in reasonable time.  I was seeing 3000 point trajectory taking ~15 seconds.  This fix allows the user to set this downsampling density in minimum radians of motion between two waypoints to something else (presumably higher like 0.5 degrees [0.00875 radians]) in order to drastically improve the speed of this algorithm.

(cherry picked from commit a15551f)
v4hn pushed a commit to v4hn/moveit that referenced this pull request Jul 3, 2020
…ration (moveit#2185)

MoveIt wrapper to Time Optimal Trajectory Generation downsamples trajectory, but its hard coded to keep waypoints with at least 0.001 radians of motion on a joint.  For very long and/or dense input trajectories, the downsampled trajectory is still way too large for the iterative optimization algorithm to finish in reasonable time.  I was seeing 3000 point trajectory taking ~15 seconds.  This fix allows the user to set this downsampling density in minimum radians of motion between two waypoints to something else (presumably higher like 0.5 degrees [0.00875 radians]) in order to drastically improve the speed of this algorithm.

(cherry picked from commit a15551f)
@tylerjw tylerjw mentioned this pull request Jul 18, 2020
20 tasks
@pbeeson pbeeson deleted the feature/settable_density_in_time_optimal_trajectory branch August 11, 2020 18:40
sjahr added a commit to sjahr/moveit that referenced this pull request Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants