-
Notifications
You must be signed in to change notification settings - Fork 938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parameterize input trajectory density of Time Optimal trajectory generation #2185
Merged
v4hn
merged 1 commit into
moveit:master
from
pbeeson:feature/settable_density_in_time_optimal_trajectory
Jul 3, 2020
Merged
Parameterize input trajectory density of Time Optimal trajectory generation #2185
v4hn
merged 1 commit into
moveit:master
from
pbeeson:feature/settable_density_in_time_optimal_trajectory
Jul 3, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ectory, but its hard coded to keep waypoints with at least 0.001 radians of motion on a joint. For very long and/or dense input trajectories, the downsampled trajectory is still way too large for the iterative optimization algorithm to finish in reasonable time. I was seeing 3000 point trajectory taking ~15 seconds. This fix allows the user to set this downsampling density in minimum radians of motion between two waypoints to something else (presumably higher like 0.5 degrees [0.00875 radians]) in order to drastically improve the speed of this algorithm.
v4hn
approved these changes
Jul 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging as straight-forward extension.
Congrats on getting your first MoveIt pull request merged and improving open source robotics! |
Thanks @pbeeson . I was annoyed by that hardcoded value as well when I looked through this, but did not have a reason to make it configurable. |
v4hn
pushed a commit
to v4hn/moveit
that referenced
this pull request
Jul 3, 2020
…ration (moveit#2185) MoveIt wrapper to Time Optimal Trajectory Generation downsamples trajectory, but its hard coded to keep waypoints with at least 0.001 radians of motion on a joint. For very long and/or dense input trajectories, the downsampled trajectory is still way too large for the iterative optimization algorithm to finish in reasonable time. I was seeing 3000 point trajectory taking ~15 seconds. This fix allows the user to set this downsampling density in minimum radians of motion between two waypoints to something else (presumably higher like 0.5 degrees [0.00875 radians]) in order to drastically improve the speed of this algorithm. (cherry picked from commit a15551f)
v4hn
pushed a commit
to v4hn/moveit
that referenced
this pull request
Jul 3, 2020
…ration (moveit#2185) MoveIt wrapper to Time Optimal Trajectory Generation downsamples trajectory, but its hard coded to keep waypoints with at least 0.001 radians of motion on a joint. For very long and/or dense input trajectories, the downsampled trajectory is still way too large for the iterative optimization algorithm to finish in reasonable time. I was seeing 3000 point trajectory taking ~15 seconds. This fix allows the user to set this downsampling density in minimum radians of motion between two waypoints to something else (presumably higher like 0.5 degrees [0.00875 radians]) in order to drastically improve the speed of this algorithm. (cherry picked from commit a15551f)
sjahr
added a commit
to sjahr/moveit
that referenced
this pull request
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MoveIt wrapper to Time Optimal Trajectory Generation downsamples trajectory, but its hard coded to keep waypoints with at least 0.001 radians of motion on a joint. For very long and/or dense input trajectories, the downsampled trajectory is still way too large for the iterative optimization algorithm to finish in reasonable time. I was seeing 3000 point trajectory taking ~15 seconds. This fix allows the user to set this downsampling density in minimum radians of motion between two waypoints to something else (presumably higher like 0.5 degrees [0.00875 radians]) in order to drastically improve the speed of this algorithm.
Checklist