[melodic] Fix deferred robot model loading #2245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4e72ac5 as the delayed loading results in link properties NOT being loaded. Additionally, this partially applies moveit#1625, namely hiding the robot until the first message was received.
This is a (in my opinion) rather dirty workaround because RViz enables Displays systematically *before* loading their properties. So the patch loads the required property a second time *before* everything else. Assuming this ever changes we can remove this code again. A Display's "enabled" state is encoded in a boolean property the Display inherits from. The way loading works (recursively running through the properties) this special property is loaded first and triggers onEnable because of the Property's changed() signal. A second "Enabled" property exists in RViz's Displays but does not change behavior at all.
This was referenced Aug 10, 2020
Merged
Codecov Report
@@ Coverage Diff @@
## melodic-devel #2245 +/- ##
=================================================
+ Coverage 51.18% 51.77% +0.59%
=================================================
Files 314 318 +4
Lines 24210 24432 +222
=================================================
+ Hits 12391 12650 +259
+ Misses 11819 11782 -37
Continue to review full report at Codecov.
|
rhaschke
added a commit
to ubi-agni/moveit
that referenced
this pull request
Sep 1, 2020
... to actually show the robot of the RobotStateDisplay (which is hidden initially since moveit#2245).
pull bot
pushed a commit
to shadow-robot/moveit
that referenced
this pull request
Sep 3, 2020
... to actually show the robot of the RobotStateDisplay (which is hidden initially since moveit#2245).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #2244.