Fix deferred robot model loading #2244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4e72ac5 as the delayed loading results in link properties NOT being loaded.
This is a (in my opinion) rather dirty workaround because RViz enables Displays systematically *before* loading their properties. So the patch loads the required property a second time *before* everything else. Assuming this ever changes we can remove this code again. A Display's "enabled" state is encoded in a boolean property the Display inherits from. The way loading works (recursively running through the properties) this special property is loaded first and triggers onEnable because of the Property's changed() signal. A second "Enabled" property exists in RViz's Displays but does not change behavior at all.
I would consider it a rewrite. @furushchev please have a try on whether this works as expected in your setup. |
It is cleaning the history of #2223, which didn't reflect (anymore) what we actually did 😉 |
Codecov Report
@@ Coverage Diff @@
## master #2244 +/- ##
=======================================
Coverage 57.73% 57.73%
=======================================
Files 326 326
Lines 25629 25629
=======================================
Hits 14797 14797
Misses 10832 10832
Continue to review full report at Codecov.
|
|
Ping @furushchev: This is awaiting your approval. |
v4hn
approved these changes
Aug 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cleanup of #2223. Fixes #2222.
Note that the melodic-devel branch is missing #1625. For this reason the PR here doesn't apply 1:1 to melodic.
I will file a similar PR for melodic.