-
Notifications
You must be signed in to change notification settings - Fork 938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A ROS service to reset the Servo status #2246
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2246 +/- ##
==========================================
- Coverage 57.73% 57.40% -0.33%
==========================================
Files 326 326
Lines 25629 25633 +4
==========================================
- Hits 14797 14715 -82
- Misses 10832 10918 +86
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I like this. Also can handle something else I have noticed: Before this PR, nothing resets the status back to normal (NO_WARNING). Meaning if you ever get into a status, you are stuck there until a different (non-normal) status occurs. Example: If you approach a collision and get the DECELERATE_FOR_COLLISION warning, then back away from the collision, you will still be in the DECELERATE_FOR_COLLISION status (and it's published continuously) even though you may now be fine and in a state I think should have status NO_WARNING. This PR should at least allow the user to reset that manually. I have thought about resetting the status every cycle after it is published, but this would still cause the problem Andy is having (but would be nicer to the user in situations except for needing to move while in collision) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
We were experiencing an issue where the arm starts in contact with a table. That initial collision needs to be reset before Servo works. This adds a ROS service to perform that reset.