Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moveit_cpp: Cover another failure path in planning pipeline loading #2336

Merged
merged 1 commit into from
Oct 5, 2020
Merged

moveit_cpp: Cover another failure path in planning pipeline loading #2336

merged 1 commit into from
Oct 5, 2020

Conversation

AndyZe
Copy link
Member

@AndyZe AndyZe commented Oct 1, 2020

Add a more informative error message, and cover another potential failure condition.

@codecov
Copy link

codecov bot commented Oct 1, 2020

Codecov Report

Merging #2336 into master will decrease coverage by 0.01%.
The diff coverage is 33.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2336      +/-   ##
==========================================
- Coverage   56.73%   56.73%   -0.00%     
==========================================
  Files         283      283              
  Lines       25455    25457       +2     
==========================================
+ Hits        14440    14441       +1     
- Misses      11015    11016       +1     
Impacted Files Coverage Δ
...s/planning_interface/moveit_cpp/src/moveit_cpp.cpp 64.17% <33.34%> (-0.24%) ⬇️
...ma_kinematics_plugin/src/lma_kinematics_plugin.cpp 71.23% <0.00%> (-3.59%) ⬇️
...raint_samplers/src/default_constraint_samplers.cpp 82.17% <0.00%> (-0.34%) ⬇️
moveit_core/robot_state/src/robot_state.cpp 46.24% <0.00%> (+0.10%) ⬆️
...dl_kinematics_plugin/src/kdl_kinematics_plugin.cpp 76.96% <0.00%> (+0.44%) ⬆️
...nning_scene_monitor/src/planning_scene_monitor.cpp 68.97% <0.00%> (+0.45%) ⬆️
...on/pick_place/src/approach_and_translate_stage.cpp 73.39% <0.00%> (+0.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89d63e8...9c6c08c. Read the comment docs.

@AndyZe AndyZe closed this Oct 1, 2020
@AndyZe
Copy link
Member Author

AndyZe commented Oct 1, 2020

Accidentally closed this by pushing an empty changeset

@AndyZe AndyZe reopened this Oct 1, 2020
Copy link
Member

@tylerjw tylerjw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More helpful error messages are always nice. Thank you.

@JafarAbdi JafarAbdi merged commit 9d917fb into moveit:master Oct 5, 2020
@tylerjw tylerjw mentioned this pull request Oct 23, 2020
57 tasks
tylerjw pushed a commit to tylerjw/moveit that referenced this pull request Oct 23, 2020
tylerjw pushed a commit to tylerjw/moveit that referenced this pull request Oct 27, 2020
tylerjw pushed a commit that referenced this pull request Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants