Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock the Bullet collision environment, for thread safety #2598

Merged
merged 2 commits into from
Apr 12, 2021

Conversation

v4hn
Copy link
Contributor

@v4hn v4hn commented Apr 12, 2021

Replaces #2481 and adds minor refinements.

Please review and merge @AndyZe. You disabled maintainer-pushes to your fork, so I had to create a new pull-request.

@v4hn v4hn requested a review from rhaschke as a code owner April 12, 2021 12:04
@v4hn v4hn force-pushed the andyz/lock_bullet_collision_env branch from cf694f7 to e4ab2a1 Compare April 12, 2021 12:05
@codecov
Copy link

codecov bot commented Apr 12, 2021

Codecov Report

Merging #2598 (e4ab2a1) into master (90e70a5) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2598      +/-   ##
==========================================
- Coverage   60.54%   60.50%   -0.04%     
==========================================
  Files         402      402              
  Lines       29606    29543      -63     
==========================================
- Hits        17922    17871      -51     
+ Misses      11684    11672      -12     
Impacted Files Coverage Δ
.../collision_detection_bullet/collision_env_bullet.h 100.00% <ø> (ø)
...sion_detection_bullet/src/collision_env_bullet.cpp 78.03% <100.00%> (-1.19%) ⬇️
...on/pick_place/src/approach_and_translate_stage.cpp 73.24% <0.00%> (-0.70%) ⬇️
...meterization/work_space/pose_model_state_space.cpp 83.34% <0.00%> (-0.64%) ⬇️
...dl_kinematics_plugin/src/kdl_kinematics_plugin.cpp 81.00% <0.00%> (-0.41%) ⬇️
.../move_group_interface/src/move_group_interface.cpp 47.12% <0.00%> (-0.19%) ⬇️
...nning_scene_monitor/src/planning_scene_monitor.cpp 68.68% <0.00%> (-0.13%) ⬇️
.../ompl_interface/src/detail/constrained_sampler.cpp 59.46% <0.00%> (+16.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90e70a5...e4ab2a1. Read the comment docs.

@AndyZe
Copy link
Member

AndyZe commented Apr 12, 2021

You disabled maintainer-pushes to your fork, so I had to create a new pull-request.

Sorry for the inconvenience

@tylerjw tylerjw closed this Apr 12, 2021
@tylerjw tylerjw reopened this Apr 12, 2021
@v4hn v4hn merged commit ae770f7 into moveit:master Apr 12, 2021
@v4hn
Copy link
Contributor Author

v4hn commented Apr 12, 2021

Thank you for patching the issue @AndyZe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants