Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixups in PlanningSceneDisplay #2618

Merged
merged 3 commits into from
Apr 26, 2021
Merged

Conversation

rhaschke
Copy link
Contributor

These commits fix some minor issues I noticed when looking into #2612. See individual commit messages for details.

@codecov
Copy link

codecov bot commented Apr 25, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@a3a4d8f). Click here to learn what that means.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2618   +/-   ##
=========================================
  Coverage          ?   60.47%           
=========================================
  Files             ?      402           
  Lines             ?    29614           
  Branches          ?        0           
=========================================
  Hits              ?    17906           
  Misses            ?    11708           
  Partials          ?        0           
Impacted Files Coverage Δ
...nclude/moveit/robot_state/cartesian_interpolator.h 85.72% <0.00%> (ø)
...al_motion_planner/src/trajectory_generator_ptp.cpp 98.94% <75.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3a4d8f...b598820. Read the comment docs.

Copy link
Member

@tylerjw tylerjw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Thank you!

@v4hn v4hn merged commit 7b6848f into moveit:master Apr 26, 2021
@rhaschke rhaschke deleted the cleanup-PSD branch April 26, 2021 08:29
sjahr pushed a commit to sjahr/moveit that referenced this pull request Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants