support arbitrary realtime-factors in trajectory visualization #2745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fact that trajectory visualization ignored the time parameterization by default and that the only way to change this is the special value "REALTIME" always bothered me. I changed the default to a realtime factor of 3x to get a nice preview of the trajectory when using the "Plan&Execute" button.
v4hn
force-pushed
the
pr-master-rt-factor-trajectories
branch
from
bec0d73
to
28b42f8
Compare
Codecov Report
@@ Coverage Diff @@
## master #2745 +/- ##
==========================================
+ Coverage 60.46% 60.47% +0.01%
==========================================
Files 402 402
Lines 29659 29659
==========================================
+ Hits 17931 17932 +1
+ Misses 11728 11727 -1
Continue to review full report at Codecov.
|
rhaschke
approved these changes
Jun 29, 2021
Comment on lines
+361
to
+362
| state_display_time_property_->setStdString(DEFAULT_TIME_STRING); | ||
| return DEFAULT_TIME_VALUE; |
There was a problem hiding this comment.
It is somewhat weird that you call a setter within this getter method, but I cannot propose a nicer solution w/o duplicating code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fact that trajectory visualization ignored the time parameterization by default
and that the only way to change this is the special value "REALTIME" always bothered me.
I changed the default to a realtime factor of 3x to get a nice preview of the trajectory
when using the "Plan&Execute" button.
rviz-rt-factors.mp4