Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get_planning_pipeline_id in Python MGI #2753

Merged
merged 1 commit into from
Jul 8, 2021

Conversation

felixvd
Copy link
Contributor

@felixvd felixvd commented Jul 7, 2021

Fixes #2752 , which was introduced with the new feature in #2622. I should have made get_planning_pipeline_id without an argument.

It also adds some debugging prints, which should be helpful.

@felixvd felixvd force-pushed the pr-fix-planning-pipeline-selection branch from e0646a1 to 93d3228 Compare July 7, 2021 14:52
@felixvd felixvd changed the title Fix planner selection in MotionSequenceAction and Python Fix planner selection in Python MGI Jul 7, 2021
@felixvd felixvd changed the title Fix planner selection in Python MGI Fix get_planning_pipeline_id in Python MGI Jul 7, 2021
@codecov
Copy link

codecov bot commented Jul 7, 2021

Codecov Report

Merging #2753 (a0c6702) into master (f72930c) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2753      +/-   ##
==========================================
- Coverage   60.47%   60.44%   -0.03%     
==========================================
  Files         402      404       +2     
  Lines       29660    29670      +10     
==========================================
- Hits        17933    17930       -3     
- Misses      11727    11740      +13     
Impacted Files Coverage Δ
.../ompl_interface/src/detail/constrained_sampler.cpp 43.25% <0.00%> (-16.21%) ⬇️
...sion_detection_bullet/src/collision_env_bullet.cpp 78.75% <0.00%> (-0.99%) ⬇️
...meterization/work_space/pose_model_state_space.cpp 82.70% <0.00%> (-0.64%) ⬇️
..._detection/src/allvalid/collision_env_allvalid.cpp 9.31% <0.00%> (-0.45%) ⬇️
...raint_samplers/src/default_constraint_samplers.cpp 82.59% <0.00%> (-0.32%) ⬇️
...istance_field/src/collision_env_distance_field.cpp 63.27% <0.00%> (-0.16%) ⬇️
...ene/include/moveit/planning_scene/planning_scene.h 53.13% <0.00%> (ø)
...e/include/moveit/kinematics_base/kinematics_base.h 74.08% <0.00%> (ø)
...collision_detection/collision_detector_allocator.h 100.00% <0.00%> (ø)
...ield/collision_detector_allocator_distance_field.h 0.00% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f72930c...a0c6702. Read the comment docs.

@felixvd felixvd force-pushed the pr-fix-planning-pipeline-selection branch from 93d3228 to a0c6702 Compare July 8, 2021 10:48
Copy link
Contributor

@v4hn v4hn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dumb bug indeed...

@v4hn v4hn merged commit 831c638 into moveit:master Jul 8, 2021
rr-tom-noble pushed a commit to rivelinrobotics/rivelin_moveit that referenced this pull request Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extra argument in get_planning_pipeline_id
2 participants