Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MotionPlanningFrame: Gracefully handle undefined parent widget #2833

Merged
merged 1 commit into from
Aug 23, 2021

Conversation

rhaschke
Copy link
Contributor

If the MP plugin was created in a non-rviz context (e.g. directly via librviz),
there might be no window manager and thus no parent widget available for panels.

This fixes ros-visualization/rviz#1653.

If the MP plugin was created in a non-rviz context (e.g. directly via librviz),
there might be no window manager and thus no parent widget available for panels.
@codecov
Copy link

codecov bot commented Aug 22, 2021

Codecov Report

Merging #2833 (976e22e) into master (0d38983) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2833      +/-   ##
==========================================
+ Coverage   60.80%   60.81%   +0.01%     
==========================================
  Files         366      366              
  Lines       31717    31717              
==========================================
+ Hits        19282    19284       +2     
+ Misses      12435    12433       -2     
Impacted Files Coverage Δ
...meterization/work_space/pose_model_state_space.cpp 80.51% <0.00%> (-1.88%) ⬇️
...nning_scene_monitor/src/planning_scene_monitor.cpp 68.27% <0.00%> (+0.14%) ⬆️
...dl_kinematics_plugin/src/kdl_kinematics_plugin.cpp 78.25% <0.00%> (+0.39%) ⬆️
...on/pick_place/src/approach_and_translate_stage.cpp 74.03% <0.00%> (+0.65%) ⬆️
...ipulation/pick_place/src/manipulation_pipeline.cpp 71.30% <0.00%> (+1.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d38983...976e22e. Read the comment docs.

@v4hn v4hn merged commit 7cea1f2 into moveit:master Aug 23, 2021
@rhaschke rhaschke deleted the fix-librviz-usage branch August 23, 2021 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

librviz : Creating a MotionPlanning display in Noetic without crashing
2 participants