Remove flakiness from constraint samplers test.

[tahsinkose]

Description

Follow-up of #3112. This removes the flakiness from the constraint sampler test by adding another seed.

Checklist

• Required by CI: Code is auto formatted using clang-format
• While waiting for someone to review your request, please help review another open pull request to support the maintainers

[tahsinkose]

PTAL @rhaschke 🙏🏼

[codecov]

Codecov Report

Merging #3135 (e7efa96) into master (5bf60e7) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3135      +/-   ##
==========================================
- Coverage   61.57%   61.56%   -0.01%     
==========================================
  Files         376      376              
  Lines       33317    33308       -9     
==========================================
- Hits        20511    20502       -9     
  Misses      12806    12806              

Impacted Files	Coverage Δ
moveit_ros/planning/moveit_cpp/src/moveit_cpp.cpp	67.45% <0.00%> (-1.39%)	⬇️
...nning_scene_monitor/src/planning_scene_monitor.cpp	66.35% <0.00%> (-0.12%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bf60e7...e7efa96. Read the comment docs.

[rhaschke]

While another seed should fix the flaky test, I guess your original intention was to test the API with and without the seed set. As the test fails here:
https://github.com/ros-planning/moveit/blob/0d46974ac7c3fe7f3aa2128f907c3bd2d78a25c6/moveit_core/constraint_samplers/test/test_constraint_samplers.cpp#L1226

What about increasing the number of attempts from 1 to say 5?

[tahsinkose]

Can definitely give a try @rhaschke 👍🏼

[rhaschke]

Looks good. Hopefully, this should fix the flaky test.