Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon to #3124 #3142

Merged
merged 6 commits into from
May 18, 2022
Merged

Addon to #3124 #3142

merged 6 commits into from
May 18, 2022

Conversation

rhaschke
Copy link
Contributor

This adds another test case to #3124 and adds some further minor improvements to the original PR.

@rhaschke rhaschke requested a review from JafarAbdi May 17, 2022 17:43
@rhaschke rhaschke requested a review from felixvd as a code owner May 17, 2022 17:43
@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #3142 (4fd5ed2) into master (9202830) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3142   +/-   ##
=======================================
  Coverage   61.63%   61.63%           
=======================================
  Files         376      376           
  Lines       33314    33314           
=======================================
  Hits        20530    20530           
  Misses      12784    12784           
Impacted Files Coverage Δ
moveit_core/planning_scene/src/planning_scene.cpp 64.89% <ø> (ø)
...ipulation/pick_place/src/manipulation_pipeline.cpp 71.91% <0.00%> (-1.65%) ⬇️
...nning_scene_monitor/src/planning_scene_monitor.cpp 66.35% <0.00%> (-0.12%) ⬇️
...meterization/work_space/pose_model_state_space.cpp 81.77% <0.00%> (+1.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9202830...4fd5ed2. Read the comment docs.

Copy link
Contributor

@JafarAbdi JafarAbdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the update!

@JafarAbdi JafarAbdi merged commit 3cbcbad into moveit:master May 18, 2022
@rhaschke rhaschke deleted the pr-rs_diff branch May 18, 2022 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants