Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PlanarJointModel::satisfiesPositionBounds #3160

Conversation

rcywongaa
Copy link
Contributor

Description

Backport from moveit/moveit2#1353

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@rcywongaa rcywongaa requested a review from tylerjw as a code owner June 13, 2022 21:31
@welcome
Copy link

welcome bot commented Jun 13, 2022

Thanks for helping in improving MoveIt and open source robotics!

@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #3160 (3dad65d) into master (e364749) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3160      +/-   ##
==========================================
- Coverage   61.61%   61.60%   -0.01%     
==========================================
  Files         376      376              
  Lines       33318    33318              
==========================================
- Hits        20527    20521       -6     
- Misses      12791    12797       +6     
Impacted Files Coverage Δ
moveit_core/robot_model/src/planar_joint_model.cpp 77.12% <100.00%> (ø)
.../ompl_interface/src/detail/constrained_sampler.cpp 43.91% <0.00%> (-17.07%) ⬇️
...ipulation/pick_place/src/manipulation_pipeline.cpp 71.91% <0.00%> (-1.65%) ⬇️
...raint_samplers/src/default_constraint_samplers.cpp 80.06% <0.00%> (+0.29%) ⬆️
...dl_kinematics_plugin/src/kdl_kinematics_plugin.cpp 78.28% <0.00%> (+0.38%) ⬆️
...on/pick_place/src/approach_and_translate_stage.cpp 75.76% <0.00%> (+0.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e364749...3dad65d. Read the comment docs.

@vatanaksoytezer vatanaksoytezer merged commit a436a97 into moveit:master Jun 14, 2022
@welcome
Copy link

welcome bot commented Jun 14, 2022

Congrats on getting your first MoveIt pull request merged and improving open source robotics!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants