Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CHANGELOG encoding for 0.9.1 (Fix #318). #327

Merged
merged 1 commit into from
Oct 31, 2016

Conversation

130s
Copy link
Contributor

@130s 130s commented Oct 29, 2016

Description

Quick fix to #318

@severin-lemaignan @v4hn Editor tools I'm using don't seem to handle correctly your name (I'll have to fix this in the near future). Hope this change would be ok for you for now.

Checklist

  • Required: Code is auto formatted using clang-format
  • Extended the tutorials / documentation, if necessary reference
    • --> Not applicable; this is a fix.
  • Include a screenshot if changing a GUI
    • --> Not applicable; no GUI.
  • Optional: Created tests, which fail without this PR reference
    • --> Since this encoding issue have happened multiple times, I have to think of adding a check.
  • Optional: Decide if this should be cherry-picked to other current ROS branches (Indigo, Jade, Kinetic)
    • --> Not applicable since this is required by kinetic-devel only.

@severin-lemaignan
Copy link
Contributor

Even though I'm sad that in 2016 UTF8 is not yet the default everywhere, I can leave with it, yes! ;-)

@v4hn
Copy link
Contributor

v4hn commented Oct 31, 2016

@130s Please fix your setup one of these days. :)

At least this time I'm not the only one blocking the release because of their name :D.

Merging.

@v4hn v4hn merged commit c9ba078 into moveit:kinetic-devel Oct 31, 2016
@130s 130s deleted the fix/318_encoding branch October 31, 2016 13:07
@davetcoleman
Copy link
Member

Thank you @130s !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants