Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silent "empty quaternion" warning from poseMsgToEigen() #3435

Merged
merged 1 commit into from May 28, 2023

Conversation

rhaschke
Copy link
Contributor

@rhaschke rhaschke commented May 18, 2023

Old-style code, not specifying a pose for a CollisionObject is handled specially (using the only shape's pose for the object).
Thus, there is no need to apply poseMsgToEigen() on that empty pose, which would trigger a warning.

@rhaschke rhaschke requested a review from felixvd as a code owner May 18, 2023 12:19
@rhaschke rhaschke requested review from v4hn and removed request for felixvd May 18, 2023 12:19
@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03 🎉

Comparison is base (55d2019) 61.74% compared to head (fa6331c) 61.76%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3435      +/-   ##
==========================================
+ Coverage   61.74%   61.76%   +0.03%     
==========================================
  Files         385      385              
  Lines       34061    34061              
==========================================
+ Hits        21028    21036       +8     
+ Misses      13033    13025       -8     
Impacted Files Coverage Δ
moveit_core/planning_scene/src/planning_scene.cpp 66.73% <100.00%> (ø)

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rhaschke rhaschke merged commit bc81091 into moveit:master May 28, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant