[jade] address gcc6 build error #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With gcc6, compiling fails with `stdlib.h: No such file or directory`, as including '-isystem /usr/include' breaks with gcc6, cf., https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70129. This commit addresses this issue for this package in almost the same way it was addressed in various other ROS packages. A list of related commits and pull requests is at: ros/rosdistro#12783 Particularly when searching for the Boost library CMake sets Boost_INCLUDE_DIRS to @sysRoot@/usr/include which should be avoided in the `-isystem` option of gcc. The same goes for OpenCV. Signed-off-by: Dmitry Rozhkov <dmitry.rozhkov@linux.intel.com>
de-vri-es
suggested changes
Mar 5, 2017
moveit_ros/perception/CMakeLists.txt
Outdated
| @@ -70,12 +70,13 @@ include_directories(mesh_filter/include | |||
| occupancy_map_monitor/include | |||
| pointcloud_octomap_updater/include | |||
| semantic_world/include | |||
| ${OpenCV_INCLUDE_DIRS} | |||
| ${Boost_INCLUDE_DIRS} | |||
| ${catkin_INCLUDE_DIRS} | |||
| ) | |||
| include_directories(SYSTEM | |||
| ${OpenCV_INCLUDE_DIRS} | |||
There was a problem hiding this comment.
${OpenCV_INCLUDE_DIRS} should be removed from the SYSTEM list I believe.
Signed-off-by: Dmitry Rozhkov <dmitry.rozhkov@linux.intel.com>
davetcoleman
force-pushed
the
jade-gcc6-build
branch
from
a7759b9
to
154f016
Compare
de-vri-es
approved these changes
Mar 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #423