add Qt-moc guards for boost 1.64 compatibility #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boost added some more constructs that moc fails to parse recently. Now Qt's moc fails when any **message header** is included without the guard. The corresponding error message is AutoMoc: Error: moc process for moveit_rviz_plugin_render_tools_autogen/QDX35O74K6/moc_trajectory_panel.cpp failed: /usr/include/boost/predef/language/stdc.h:52: Parse error at "defined"
davetcoleman
approved these changes
Jun 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know boost 1.64 is still far in the future for Ubuntu users, but other
distributions already see this (or will in the near future).
I know this is probably impossible to test for others.
If CI succeeds, this should be good enough for this request.
boost added some more constructs that moc fails to parse recently.
Now Qt's moc fails when any message header is included without the guard.
The corresponding error message is
AutoMoc: Error: moc process for moveit_rviz_plugin_render_tools_autogen/QDX35O74K6/moc_trajectory_panel.cpp failed:
/usr/include/boost/predef/language/stdc.h:52: Parse error at "defined"