CSM: wait for *active* joint states only #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't expect that drivers publish the transforms for fixed joints Fixup for 739a85a It wasn't a problem before because the checks used variable names and fixed joints do not have variables. So nothing was checked.
davetcoleman
approved these changes
Mar 11, 2018
JafarAbdi
pushed a commit
to JafarAbdi/moveit
that referenced
this pull request
Mar 24, 2022
…2_control nodes (moveit#792) * allow handle instantiation if action server does not exist * reload controller info before ensuring active controllers * make isConnected protected change MoveItSimpleControllerManager to always create new controller handles even if their associated action servers are not available * add more documentation for ActionBasedControllerHandle * fix string concatenation to appease clang-tidy * remove node_ member variable and add clarifying comment * add a more useful parameter name concatenation function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets rid of many warnings on incomplete robot states due to missing state information for all fixed joints. We don't expect that drivers publish the transforms for fixed joints
Fixup for 739a85a
It wasn't a problem before because the checks used variable names
and fixed joints do not have variables. So nothing was checked.