Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow optional namespace args #929

Merged
merged 2 commits into from
Jun 3, 2018
Merged

Conversation

rhaschke
Copy link
Contributor

This fixes another regression introduced by #835: The newly introduced optional ns args are not declared as optional to python, thus resulting in errors like the following if omitted:

Traceback (most recent call last):
  File "/homes/rhaschke/src/ros/src/agni/agni-manipulation/agni_grasp_manager/scripts/grasp_manager.py", line 78, in __init__
    r = RobotInterface("robot_description")
Boost.Python.ArgumentError: Python argument types in
    RobotInterface.__init__(RobotInterface, str)
did not match C++ signature:
    __init__(_object*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >)

@gavanderhoorn
Copy link
Contributor

I believe this was also reported by a user on ROS Answers: moveit_commander_cmdline.py Error.

@rhaschke
Copy link
Contributor Author

@willcbaker Please review as you originally requested #835.
There is also another open issue pending with this: #835 (review)

@rhaschke rhaschke added melodic PRs to be merged into melodic branch kinetic PRs to be merged into kinetic branch regression bugs newly introduced by latest release and removed melodic PRs to be merged into melodic branch labels May 31, 2018
@willcbaker
Copy link
Contributor

@rhaschke looks good visually, still unable to test at this time

@v4hn v4hn merged commit 1543719 into moveit:kinetic-devel Jun 3, 2018
v4hn pushed a commit that referenced this pull request Jun 3, 2018
allow optional namespace args

clang format of unrelated code in the same file
@v4hn
Copy link
Contributor

v4hn commented Jun 3, 2018

picked to melodic

dg-shadow pushed a commit to shadow-robot/moveit that referenced this pull request Jul 30, 2018
allow optional namespace args

clang format of unrelated code in the same file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kinetic PRs to be merged into kinetic branch regression bugs newly introduced by latest release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants