Add missing distance check functions to allValid collision checker #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhaschke
approved these changes
Jul 17, 2018
|
@Levi-Armstrong Could you please review this (as this is related to your recent changes)? |
|
Yes, simply instantiating it would actually be a sufficient unit test ... will look at it |
|
Could we get this merged? |
rhaschke
pushed a commit
that referenced
this pull request
Sep 7, 2018
mayman99
pushed a commit
to mayman99/moveit
that referenced
this pull request
Sep 11, 2018
JafarAbdi
pushed a commit
to JafarAbdi/moveit
that referenced
this pull request
Mar 24, 2022
* Delete the pass-through option * Suppress clang warning * Handle (waypoint_count < 0) possibility Co-authored-by: Tyler Weaver <tyler@picknik.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some functions are missing for the allValid dummy collision checker plugin after latest changes