Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added param for timeout, added retries #1008

Merged

Conversation

Projects
None yet
3 participants
@dg-shadow
Copy link
Contributor

commented Jul 30, 2018

Description

Added retries param to re-attempt connection to db if timeout occurs.
Also added param for timeout.

Checklist

  • Required: Code is auto formatted using clang-format
  • Extended the tutorials / documentation, if necessary reference
  • Include a screenshot if changing a GUI
  • Optional: Created tests, which fail without this PR reference
  • Optional: Decide if this should be cherry-picked to other current ROS branches (Indigo, Jade, Kinetic)

@dg-shadow dg-shadow referenced this pull request Jul 30, 2018

Closed

F#src 1610 wait for db #1007

0 of 5 tasks complete
@dg-shadow

This comment has been minimized.

Copy link
Contributor Author

commented Aug 7, 2018

Hey. Anyone free to have a look at this?

@v4hn

v4hn approved these changes Aug 20, 2018

Copy link
Member

left a comment

Looks good and makes sense.

I approve.

@v4hn

This comment has been minimized.

Copy link
Member

commented Aug 20, 2018

incidentally, @dg-shadow could someone from Shadow have a look at Kei's sqlite implementation for the warehouse?
#123 (comment)
I believe you would also be relieved to have a lightweight replacement for the mongodb and it should remedy problems like the one you work around in this request.

@rhaschke rhaschke merged commit 791519f into ros-planning:kinetic-devel Aug 20, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

rhaschke added a commit that referenced this pull request Aug 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.