Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added param for timeout, added retries #1008

Merged
merged 1 commit into from Aug 20, 2018

Conversation

dg-shadow
Copy link
Contributor

@dg-shadow dg-shadow commented Jul 30, 2018

Description

Added retries param to re-attempt connection to db if timeout occurs.
Also added param for timeout.

Checklist

  • Required: Code is auto formatted using clang-format
  • Extended the tutorials / documentation, if necessary reference
  • Include a screenshot if changing a GUI
  • Optional: Created tests, which fail without this PR reference
  • Optional: Decide if this should be cherry-picked to other current ROS branches (Indigo, Jade, Kinetic)

@dg-shadow dg-shadow mentioned this pull request Jul 30, 2018
5 tasks
@dg-shadow
Copy link
Contributor Author

Hey. Anyone free to have a look at this?

Copy link
Contributor

@v4hn v4hn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and makes sense.

I approve.

@v4hn
Copy link
Contributor

v4hn commented Aug 20, 2018

incidentally, @dg-shadow could someone from Shadow have a look at Kei's sqlite implementation for the warehouse?
#123 (comment)
I believe you would also be relieved to have a lightweight replacement for the mongodb and it should remedy problems like the one you work around in this request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants