Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F#src 1610 wait for db #1007

Closed

Conversation

dg-shadow
Copy link
Contributor

Description

Added parameter and functionality to retry database connection if timeout occurs.
Also added param for connection timeout.

Checklist

  • Required: Code is auto formatted using clang-format
  • Extended the tutorials / documentation, if necessary reference
  • Include a screenshot if changing a GUI
  • Optional: Created tests, which fail without this PR reference
  • Optional: Decide if this should be cherry-picked to other current ROS branches (Indigo, Jade, Kinetic)

Beatriz Leon and others added 30 commits July 30, 2018 12:07
Gracefully handle active root joint, which doesn't have a parent.
Adapt final path simplification to match latest OMPL changes:
As optimizing planners, like RRT*, consume all planning time, there should be at least one final simplification step. If more time is available OMPL will continue simplifying the path. No need for checking the time in MoveIt anymore.

Resolved redundancy of parameters `longest_valid_segment_fraction` and `max_waypoint_distance`, only passing the most conservative to OMPL.
* [Fix] switch to ROS_LOGGER from CONSOLE_BRIDGE

* [Fix] clang format

* [Fix] manually fix bad clang-formatting in strings
This should not be a public message.
Especially annoying because the RViz display calls this
function quite often when displaying trajectories with attached objects.
* code clean up of moveit_core

* code clean up of moveit_core
 - /rviz/moveit/update_custom_start_state
 - /rviz/moveit/update_custom_goal_state

stopping from external:
 - /rviz/moveit/stop
bugfix: correctly check names of multidof trajectory
Upstream cmake config uses lowercase package name: omplConfig.cmake.
* clang-tidy: modernize-redundant-void-arg

* clang-tidy:modernize-use-nullptr

* clang-tidy:modernize-use-default

* clang-tidy:modernize-use-override

* clang-tidy:readability-redundant-smartptr-get

* clang-tidy:readability-simplify-boolean-expr

* clang-tidy:readability-container-size-empty

* clang-tidy:readability-named-parameter

* Updated project-wide .clang-tidy with run checks.

* One last run of clang-tidy to catch the most recent changes.

* clang-format

* Added .vscode to the gitignore.
Can now get the jacobian of a child link of a move group.
Just like moveit#878 ,
these messages should also not be printed every time by default.
Make it possible to execute a previously created plan.
- use common functions for model loading
- added small set of validations
The monitor optionally kept track of velocities, accelerations & effort too,
but never wrote them to the output variable when asked for the current state
The text says "Just set the `moveit_controller_manager` parameter" but the example uses a `arg` instead of `param`.
v4hn and others added 27 commits July 30, 2018 15:04
The robot state should be marked as diff, 
otherwise PlanningScene::isEmpty(RobotState&) will not acknowledge it as empty.
This is useful because the plan_execution allows arbitrary callbacks
to run after successful execution of individual plan_components_.

So although the *trajectory* might be empty we miss to run the
associated callbacks if we just skip the component/trajectory altogether.

This mechanism is very convenient for modular plans where some components
only invoke side effects.
* adding the max update rate parameter to the point cloud octomap updater

* adding the max update rate parameter to the depth image octomap updater

* made max_update_rate parameter optional

* walltime to time
Reset moveit_msgs::RobotState.is_diff to false whenever actually filling a RobotState msg.
This fixes a regression introduced in moveit#939.
Additionally to the global duration parameters `trajectory_execution/allowed_execution_duration_scaling` and `trajectory_execution/allowed_goal_duration_margin`, allow for controller-specific overrides,
named `allowed_execution_duration_scaling` and `allowed_goal_duration_margin`.

As opposed to the global values, the contoller-specific ones cannot be dynamically reconfigured at runtime. The global value is still used, when no controller-specific value was defined.
Otherwise, the binary builds on the buildfarm fail.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
This resolves problems when a system version of moveit is overlayed.
It could still trigger new bugs when `moveit_ros_planning_interface`
is installed in a workspace other than the current one where chomp_interface
is compiled, but this is not a big issue here because both packages
are part of the same repository and are usually compiled together.
… of trajectory initialization methods (linear, cubic, quintic-spline) (moveit#960)

* added options for trajectory initialization using (linear, cubic) interpolation in addition to quintic-spline, this can be specified in the chomp_planning.yaml file as a string parameter

* removed/cleaned redundant commented code from chomp_optimizer.cpp file

* commented print statements

* removed unused CHOMP parameters code

* applied clang-format and addressed comments

* applied clang-format and addressed comments

* added PR suggested revies/changes

* removed usused 2 lines

* generating chomp_planning.yaml and chomp_planning_pipeline.launch.xml from the moveit setup assistant

* restored CHOMP, hamiltonian monte carlo (HMC) based code and commented it

* applied clang format
* fixed compiler warnings
* disable unittests for moveit_ros_perception ... due to broken Mesa OpenGL (since version 17.x?)
@dg-shadow dg-shadow closed this Jul 30, 2018
@dg-shadow dg-shadow deleted the F#SRC-1610_wait_for_db branch July 30, 2018 15:10
@dg-shadow
Copy link
Contributor Author

Deleted to clean up commit history. New pr created #1008

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet