-
Notifications
You must be signed in to change notification settings - Fork 938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix travis: suppress catkin_lint error for eigenpy #1734
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a TODO to remove this for noetic?
This is not related to Noetic. We can remove it if catkin_lint relaxes the check. |
And that's the way I would like to handle this in the future, as I agree that this should not be a catkin component if it's not built through catkin. Thus the request for the TODO. Anyway, as we plan to remove the dependency in the future in favor of boost_python anyway, I'm also fine with this as-is until then. Can be merged as soon as CI succeeds. |
If you agree that eigenpy shouldn't be a catkin component if it's not building via catkin, we should directly prefer a cleaner (but more laborious) solution as suggested in #1734 (comment). |
I did not look at the actual implementation of the catkin-compatible cmake config. |
Unless a header lives in the same or a child directory of the file including it, it's recommended to use <> for the #include statement. For more information, see the C++ Core Guidelines item SF.12 https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#sf12-prefer-the-quoted-form-of-include-for-files-relative-to-the-including-file-and-the-angle-bracket-form-everywhere-else
See fkie/catkin_lint#73