Fix Travis: treat eigenpy as a system dependency #1737
Conversation
fix stack-of-tasks/eigenpy#195 Since moveit#1737, eigenpy is found using find_package, so we can get all required informations to find headers and link to shared objects with a target_link_libraries to the eigenpy::eigenpy imported CMake target.
|
I'm sorry but I don't understand this push and all the eigenpy in moveit. I'm trying to build moveit in debian buster and it fails because it doesn't find eigenpy: find_package(eigenpy REQUIRED) AFAIK this CMake line implies that or exists a "Findeigenpy.cmake" or eigenpy has installed eigenpyConfig.cmake or eigenpy-config.cmake files. Checking eigenpy files and my installation eigenpy doesn't install that files. So, how do you solve it? |
|
@lepalom, please indicate next time that you are using Noetic. Did you install the ROS eigenpy package: |
|
Nops! I'm not using Noetic. I have a list of packages (melodic version) that I want to use in my debian buster, so I prepare to build them. However, I have detected that I carried some old version 1.3.2 of eigenpy so the errors come from there. Updating it, I found eigenpy 2.3.1-1 for melodic that install the cmake files. Sorry for the noise. But building from source a complete ros distro is not an easy task. |
That's why we typically try to avoid it ;) |
|
Better if I don't explain to do it also with Python 3 only :-( |
|
building from source a complete ros distro ... Python 3 _only_ :-(
I do that on a more or less biweekly basis for a non-Debian system
and it works quite well with the occational patch.
Hang in there, it's quite straightforward once you figured out a few things. :)
|
changing all the shebangs?
Please, could you give me that few things ... I'm using a Debian system |
fix stack-of-tasks/eigenpy#195 Since #1737, eigenpy is found using find_package, so we can get all required informations to find headers and link to shared objects with a target_link_libraries to the eigenpy::eigenpy imported CMake target.
|
I don't know about debian, but my |
|
Well, that was one solution. But I was surfing a bit on the web and looking [https://www.python.org/dev/peps/pep-0394/] I understood that that was not a good idea. In any case, my main problems come from old packages that had problems with print " and except with , Another thing is strange behaviours. We have in debian the core system in python3 and not python2. |
|
and looking [https://www.python.org/dev/peps/pep-0394/] I understood that that was not a good idea.
I don't follow.
In any case, my main problems come from old packages that had problems with print " and except with ,
Yes, there is still a lot of migration work left to do...
Please file pull-request for as many of these issues as possible because for noetic we *need* them.
We have in debian the core system in python3 and not python2.
Now that's a debian-specific issue. ;)
|
From my point of view, your script should run in any distro. As we (developers) are moving to python3 it's important that in the shebang appears which version are you using. IMHO it's not a good idea to have /usr/bin/python. It's better to have /usr/bin/python2 or /usr/bin/python3 to have clear which version are you using. Another thing is because backward compatibility, etc. But, as ROS developers, iMHO we should be distro agnostic and ROS is too much Ubuntu centric.
And yes, it's not moveit. There are other packages with old code. |
|
At least for scripts catkin_install_python takes care of adding the correct version in the shebang line. Aside from that I do very much hope that there is no need for an API-incompatible python4 ever and python2 dies in the near future. So I do not see a reason to mark
Tell me about it, I've been fighting that fight for 6 years now and believe me, it's a stroll through the park these days to get things to compile on non-ubuntu... |
fix stack-of-tasks/eigenpy#195 Since moveit#1737, eigenpy is found using find_package, so we can get all required informations to find headers and link to shared objects with a target_link_libraries to the eigenpy::eigenpy imported CMake target.
fix stack-of-tasks/eigenpy#195 Since moveit#1737, eigenpy is found using find_package, so we can get all required informations to find headers and link to shared objects with a target_link_libraries to the eigenpy::eigenpy imported CMake target.
fix stack-of-tasks/eigenpy#195 Since moveit#1737, eigenpy is found using find_package, so we can get all required informations to find headers and link to shared objects with a target_link_libraries to the eigenpy::eigenpy imported CMake target.
fix stack-of-tasks/eigenpy#195 Since moveit#1737, eigenpy is found using find_package, so we can get all required informations to find headers and link to shared objects with a target_link_libraries to the eigenpy::eigenpy imported CMake target. (cherry picked from commit 81e64b9)
fix stack-of-tasks/eigenpy#195 Since moveit#1737, eigenpy is found using find_package, so we can get all required informations to find headers and link to shared objects with a target_link_libraries to the eigenpy::eigenpy imported CMake target.
fix stack-of-tasks/eigenpy#195 Since #1737, eigenpy is found using find_package, so we can get all required informations to find headers and link to shared objects with a target_link_libraries to the eigenpy::eigenpy imported CMake target.
Alternative to #1734.