Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prerelease test #2633

Merged
merged 1 commit into from
Apr 29, 2021
Merged

Fix prerelease test #2633

merged 1 commit into from
Apr 29, 2021

Conversation

rhaschke
Copy link
Contributor

Attempts to fix #2629 (comment)

@codecov
Copy link

codecov bot commented Apr 29, 2021

Codecov Report

Merging #2633 (913af4a) into master (db8e3e9) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 913af4a differs from pull request most recent head 30dbbc1. Consider uploading reports for the commit 30dbbc1 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2633      +/-   ##
==========================================
- Coverage   60.52%   60.51%   -0.00%     
==========================================
  Files         402      402              
  Lines       29561    29619      +58     
==========================================
+ Hits        17889    17922      +33     
- Misses      11672    11697      +25     
Impacted Files Coverage Δ
...raint_samplers/src/default_constraint_samplers.cpp 83.89% <0.00%> (-0.32%) ⬇️
moveit_core/robot_state/src/robot_state.cpp 50.77% <0.00%> (+0.10%) ⬆️
...meterization/work_space/pose_model_state_space.cpp 83.98% <0.00%> (+0.65%) ⬆️
...ove_group_interface/src/wrap_python_move_group.cpp 38.04% <0.00%> (+2.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db8e3e9...30dbbc1. Read the comment docs.

Copy link
Member

@tylerjw tylerjw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tylerjw
Copy link
Member

tylerjw commented Apr 29, 2021

It looks like it worked! https://github.com/ubi-agni/moveit/runs/2469467512

@rhaschke rhaschke merged commit efcfe97 into moveit:master Apr 29, 2021
@rhaschke rhaschke deleted the fix-prerelease-test branch April 29, 2021 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants