Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

address gcc6 build error (indigo-devel) #471

Merged
merged 1 commit into from Mar 20, 2017

Conversation

rojkov
Copy link
Contributor

@rojkov rojkov commented Mar 16, 2017

This is a continuation for #423.

Somehow I overlooked the moveit_ros/planning package which also needs the same treatment.

With gcc6, compiling fails with `stdlib.h: No such file or directory`,
as including '-isystem /usr/include' breaks with gcc6, cf.,
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70129.

This commit addresses this issue for this package in almost the same way
it was addressed in various other ROS packages. A list of related
commits and pull requests is at:

    ros/rosdistro#12783

Particularly when searching for the Boost library CMake sets
Boost_INCLUDE_DIRS to @sysRoot@/usr/include which should be
avoided in the `-isystem` option of gcc.

Signed-off-by: Dmitry Rozhkov <dmitry.rozhkov@linux.intel.com>
Copy link
Contributor

@de-vri-es de-vri-es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the follow-up :)

@v4hn v4hn merged commit 069647f into moveit:indigo-devel Mar 20, 2017
v4hn pushed a commit that referenced this pull request Mar 20, 2017
With gcc6, compiling fails with `stdlib.h: No such file or directory`,
as including '-isystem /usr/include' breaks with gcc6, cf.,
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70129.

This commit addresses this issue for this package in almost the same way
it was addressed in various other ROS packages. A list of related
commits and pull requests is at:

    ros/rosdistro#12783

Particularly when searching for the Boost library CMake sets
Boost_INCLUDE_DIRS to @sysRoot@/usr/include which should be
avoided in the `-isystem` option of gcc.

Signed-off-by: Dmitry Rozhkov <dmitry.rozhkov@linux.intel.com>
@v4hn
Copy link
Contributor

v4hn commented Mar 20, 2017

cherry-picked to jade-devel.

JafarAbdi pushed a commit to JafarAbdi/moveit that referenced this pull request Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants