Set trajectory execution monitor params under correct namespace #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkentaro
changed the title
wkentaro
force-pushed
the
traj-exec-param-correctly
branch
from
ae57332
to
b469135
Compare
|
+1 |
| <!-- Allow more than the expected execution time before triggering a trajectory cancel (applied after scaling) --> | ||
| <param name="trajectory_execution/allowed_goal_duration_margin" value="0.5"/> <!-- default 0.5 --> | ||
| <param name="allowed_goal_duration_margin" value="0.5"/> <!-- default 0.5 --> | ||
|
|
There was a problem hiding this comment.
Why did you reverted this? IMHO it makes sense to structure the param space using the "trajectory_execution" ns.
Furthermore, the namespace is needed for dynamic reconfigure. This was the point of #68.
There was a problem hiding this comment.
Sorry, obviously I didn't look at the most recent code...
wkentaro
force-pushed
the
traj-exec-param-correctly
branch
from
b469135
to
44267b7
Compare
|
@rhaschke Thanks for the review. Rebased, and fixed based on the comments. |
|
Please consider #72 (comment). Otherwise looks good to me. |
|
Thanks. Fixed. |
rhaschke
added a commit
that referenced
this pull request
Aug 18, 2016
rhaschke
pushed a commit
that referenced
this pull request
Aug 18, 2016
Added parameter allowed_goal_duration_margin to DynamicReconfigure fixes remaining issues in #68
rhaschke
pushed a commit
that referenced
this pull request
Aug 18, 2016
Added parameter allowed_goal_duration_margin to DynamicReconfigure fixes remaining issues in #68
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #61 and #68