Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chomp needs to depend on cmake_modules. #976

Merged
merged 1 commit into from Jul 12, 2018
Merged

Chomp needs to depend on cmake_modules. #976

merged 1 commit into from Jul 12, 2018

Conversation

clalancette
Copy link
Contributor

@clalancette clalancette commented Jul 10, 2018

Description

Fix the chomp package.xml to depend on cmake_modules, which is necessary to fix binary builds for it on the Melodic buildfarm. An example problem is here: http://build.ros.org/view/Mbin_ds_dS64/job/Mbin_ds_dS64__moveit_planners_chomp__debian_stretch_amd64__binary/56/consoleFull

Checklist

  • [ N/A ] Required: Code is auto formatted using clang-format
  • [ N/A ] Extended the tutorials / documentation, if necessary reference
  • [ N/A ] Include a screenshot if changing a GUI
  • [ N/A ] Optional: Created tests, which fail without this PR reference
  • Optional: Decide if this should be cherry-picked to other current ROS branches (Indigo, Jade, Kinetic) - shouldn't be necessary, as chomp is only released in Melodic.

Otherwise, the binary builds on the buildfarm fail.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@bmagyar
Copy link
Member

bmagyar commented Jul 12, 2018

Thanks, actually there are similar issues with other dependencies that are find_package-d. Wouldn't those come up on the next build? ... Scratch that, I think I overlooked a few declarations.

@bmagyar
Copy link
Member

bmagyar commented Jul 12, 2018

I'll also cherry-pick this to kinetic.

@bmagyar bmagyar merged commit 0e94d69 into moveit:melodic-devel Jul 12, 2018
bmagyar pushed a commit to bmagyar/moveit that referenced this pull request Jul 12, 2018
Otherwise, the binary builds on the buildfarm fail.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
rhaschke pushed a commit that referenced this pull request Jul 12, 2018
Otherwise, the binary builds on the buildfarm fail.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@rhaschke
Copy link
Contributor

@bmagyar Looks like you cherry-picked only to your clone. I did it for ros-planning.

@bmagyar
Copy link
Member

bmagyar commented Jul 13, 2018

Done and done :) Thanks for double checking

dg-shadow pushed a commit to shadow-robot/moveit that referenced this pull request Jul 30, 2018
Otherwise, the binary builds on the buildfarm fail.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
mayman99 pushed a commit to mayman99/moveit that referenced this pull request Aug 25, 2018
Otherwise, the binary builds on the buildfarm fail.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@clalancette clalancette deleted the chomp-cmake-modules branch October 30, 2018 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants