Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove position controllers from Hybrid Planning CMake #1285

Merged
merged 1 commit into from
May 31, 2022

Conversation

vatanaksoytezer
Copy link
Contributor

@vatanaksoytezer vatanaksoytezer commented May 31, 2022

Humble and Rolling buildfarm has been failing with the following error:

14:25:06 CMake Error at CMakeLists.txt:15 (find_package):
14:25:06   By not providing "Findposition_controllers.cmake" in CMAKE_MODULE_PATH this
14:25:06   project has asked CMake to find a package configuration file provided by
14:25:06   "position_controllers", but CMake did not find one.
14:25:06 
14:25:06   Could not find a package configuration file provided by
14:25:06   "position_controllers" with any of the following names:
14:25:06 
14:25:06     position_controllersConfig.cmake
14:25:06     position_controllers-config.cmake
14:25:06 
14:25:06   Add the installation prefix of "position_controllers" to CMAKE_PREFIX_PATH
14:25:06   or set "position_controllers_DIR" to a directory containing one of the
14:25:06   above files.  If "position_controllers" provides a separate development
14:25:06   package or SDK, be sure it has been installed.
14:25:06 

Although position_controllers is only a run depend, it has been listed in the cmake. This PR removes it in an attempt to fix the buildfarm

@vatanaksoytezer
Copy link
Contributor Author

We need a new release after this to get the buildfarm passing again

@codecov
Copy link

codecov bot commented May 31, 2022

Codecov Report

Merging #1285 (fda0780) into main (9bbe46a) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1285      +/-   ##
==========================================
+ Coverage   61.45%   61.47%   +0.02%     
==========================================
  Files         274      274              
  Lines       24940    24940              
==========================================
+ Hits        15325    15329       +4     
+ Misses       9615     9611       -4     
Impacted Files Coverage Δ
...nning_scene_monitor/src/planning_scene_monitor.cpp 45.73% <0.00%> (+0.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bbe46a...fda0780. Read the comment docs.

@JafarAbdi JafarAbdi merged commit 7a3d387 into moveit:main May 31, 2022
@AndyZe
Copy link
Member

AndyZe commented May 31, 2022

I wish you would have left a TODO to put it back. It does belong there. But no big deal.

peterdavidfagan pushed a commit to peterdavidfagan/moveit2 that referenced this pull request Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants