fix docker images #139
Merged
fix docker images #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use ARG ROS_DISTRO=dashing to build images for both, dashing and eloquent - simplify installation for ci base image - fix image ci-testing
moveit_ros_planning's package.xml refers to many non-existing packages making rosdep install fail
henningkayser
approved these changes
Dec 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another attempt to fix various issues with our ROS2 docker images:
--build-arg ROS_DISTRO=...rosdepshould ignore packages marked asCOLCON_IGNOREoctomap(currently only available fromros2-testing- awaiting the next sync)@henningkayser, when merging, please don't squash these commits. All of them are meaningful on their own and should be kept for history.