Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove clock from RobotTrajectory #1639

Merged
merged 2 commits into from
Oct 28, 2022

Conversation

tylerjw
Copy link
Member

@tylerjw tylerjw commented Oct 27, 2022

Description

Clock is never set or used by any of the methods.

@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Base: 51.07% // Head: 51.11% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (020a145) compared to base (97c7dbb).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1639      +/-   ##
==========================================
+ Coverage   51.07%   51.11%   +0.05%     
==========================================
  Files         381      381              
  Lines       31742    31742              
==========================================
+ Hits        16209    16222      +13     
+ Misses      15533    15520      -13     
Impacted Files Coverage Δ
...include/moveit/robot_trajectory/robot_trajectory.h 98.72% <ø> (ø)
moveit_ros/moveit_servo/src/pose_tracking.cpp 77.26% <0.00%> (+0.48%) ⬆️
...dl_kinematics_plugin/src/kdl_kinematics_plugin.cpp 77.15% <0.00%> (+1.08%) ⬆️
moveit_ros/moveit_servo/src/servo_calcs.cpp 67.95% <0.00%> (+1.50%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@henningkayser henningkayser merged commit cf69733 into moveit:main Oct 28, 2022
@tylerjw tylerjw deleted the remove-trajecotry-clock branch October 28, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants