Better TOTG comments #1779
Merged
Better TOTG comments #1779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 50.27% // Head: 50.24% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1779 +/- ##
==========================================
- Coverage 50.27% 50.24% -0.03%
==========================================
Files 374 374
Lines 31277 31277
==========================================
- Hits 15722 15712 -10
- Misses 15555 15565 +10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
AndyZe
reviewed
Dec 3, 2022
...jectory_processing/include/moveit/trajectory_processing/time_optimal_trajectory_generation.h
Outdated
Show resolved
Hide resolved
|
This pull request is in conflict. Could you fix it @nbbrooks? |
Tiny readability optimization - makes it a little easier for people to figure out what `path_tolerance_` does
AndyZe
force-pushed
the
nbbrooks-patch-1
branch
2 times, most recently
from
759c2cb
to
d89b848
Compare
AndyZe
approved these changes
Dec 8, 2022
AndyZe
force-pushed
the
nbbrooks-patch-1
branch
from
d89b848
to
fbf2afa
Compare
nbbrooks
commented
Dec 9, 2022
...jectory_processing/include/moveit/trajectory_processing/time_optimal_trajectory_generation.h
Show resolved
Hide resolved
AndyZe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tiny readability optimization - makes it a little easier for people to figure out what
path_tolerance_does