Minimize use of this->

[ChrisThrasher]

Description

Using the this pointer is often unnecessary. MoveIt already avoids this in most cases so this PR better cements that existing pattern. In some places it must remain because a method parameter shadows a function we're trying to call so removing this-> causes the build to break.

[tylerjw]

This is a good change, pun intended.

[codecov]

Codecov Report

Base: 50.70% // Head: 50.89% // Increases project coverage by +0.19% 🎉

Coverage data is based on head (69a3e70) compared to base (f0d3202).
Patch coverage: 26.67% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1784      +/-   ##
==========================================
+ Coverage   50.70%   50.89%   +0.19%     
==========================================
  Files         378      378              
  Lines       31728    31728              
==========================================
+ Hits        16085    16145      +60     
+ Misses      15643    15583      -60     

Impacted Files	Coverage Δ
...tance_field/src/collision_distance_field_types.cpp	35.65% <0.00%> (ø)
...e_field/include/moveit/distance_field/voxel_grid.h	95.32% <ø> (ø)
...mpl_interface/src/model_based_planning_context.cpp	50.57% <0.00%> (ø)
..._ros/robot_interaction/src/interaction_handler.cpp	0.00% <0.00%> (ø)
...t/moveit_setup_app_plugins/src/launches_widget.cpp	1.97% <0.00%> (ø)
...moveit_setup_app_plugins/src/perception_widget.cpp	0.62% <0.00%> (ø)
...t_setup_controllers/src/controller_edit_widget.cpp	0.00% <0.00%> (ø)
...oveit_setup_controllers/src/controllers_widget.cpp	0.00% <0.00%> (ø)
...etup_controllers/src/urdf_modifications_widget.cpp	1.48% <0.00%> (ø)
.../moveit_setup_framework/src/double_list_widget.cpp	0.00% <0.00%> (ø)
... and 20 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.