Remove unnecessary CMake variables and lists #1790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is in conflict. Could you fix it @tylerjw? |
ChrisThrasher
approved these changes
Dec 6, 2022
tylerjw
force-pushed
the
less_lists
branch
2 times, most recently
from
fe19846
to
d67f659
Compare
Codecov ReportBase: 50.24% // Head: 50.24% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1790 +/- ##
==========================================
+ Coverage 50.24% 50.24% +0.01%
==========================================
Files 374 374
Lines 31277 31277
==========================================
+ Hits 15711 15712 +1
+ Misses 15566 15565 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
tylerjw
force-pushed
the
less_lists
branch
4 times, most recently
from
0699dea
to
c25f782
Compare
Signed-off-by: Tyler Weaver <tyler@picknik.ai>
vatanaksoytezer
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In moveit_core CMakeLists.txt
find_packagecalls in a single group and sort them alphabetically.THIS_PACKAGE_LIBRARIESandTHIS_PACKAGE_INCLUDE_DEPENDSthat are only used in one place by putting the contents in the install.find_packageon. I think this fixes some transitive dependencies not being exported.PROJECT_NAMEandVERSION_FILE_PATH.add_subdirectorycalls.