Add JointModel::satisfiesAccelerationBounds() #2092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndyZe
commented
Apr 7, 2023
Comment on lines
+121
to
+124
| if (!other_bounds[i].velocity_bounded_) | ||
| { | ||
| continue; | ||
| } |
There was a problem hiding this comment.
Not having this previously was a bug
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2092 +/- ##
==========================================
+ Coverage 50.84% 50.89% +0.06%
==========================================
Files 391 391
Lines 32150 32140 -10
==========================================
+ Hits 16343 16355 +12
+ Misses 15807 15785 -22
... and 8 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
sjahr
approved these changes
Apr 13, 2023
mechwiz
pushed a commit
to mechwiz/moveit2
that referenced
this pull request
May 18, 2023
* Add JointModel::satisfiesAccelerationBounds() * Check Jerk bounds too * Check if bounds exist --------- Co-authored-by: Sebastian Jahr <sebastian.jahr@picknik.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a port of this MoveIt1 PR: moveit/moveit#3396
We already have versions for satisfiesPositionBounds() and satisfiesVelocityBounds(), why not Acceleration and Jerk too?