Alphabetize, smart pointer not needed #2148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2148 +/- ##
=======================================
Coverage 50.47% 50.47%
=======================================
Files 387 387
Lines 31819 31819
=======================================
Hits 16058 16058
Misses 15761 15761
☔ View full report in Codecov by Sentry. |
AndyZe
commented
May 2, 2023
sjahr
reviewed
May 3, 2023
AndyZe
force-pushed
the
andyz/butterworth_filter_cleanup
branch
from
e2f74b0
to
2706484
Compare
ibrahiminfinite
approved these changes
May 4, 2023
sjahr
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up some issues I noticed while reviewing #2129