[Servo] Remove soon-to-be obsolete functions #2175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #2175 +/- ##
==========================================
+ Coverage 50.47% 50.54% +0.07%
==========================================
Files 387 387
Lines 31790 31719 -71
==========================================
- Hits 16043 16028 -15
+ Misses 15747 15691 -56
☔ View full report in Codecov by Sentry. |
AndyZe
reviewed
May 15, 2023
There was a problem hiding this comment.
Don't forget to clean this up too:
test/servo_launch_test_common.hpp:#include <moveit_msgs/srv/change_drift_dimensions.hpp>
test/servo_launch_test_common.hpp:#include <moveit_msgs/srv/change_control_dimensions.hpp>
test/servo_launch_test_common.hpp: resolveServoTopicName("~/change_control_dimensions"));
test/servo_launch_test_common.hpp: resolveServoTopicName("~/change_drift_dimensions"));
AndyZe
changed the title
AndyZe
approved these changes
May 15, 2023
ibrahiminfinite
force-pushed
the
remove_unused
branch
from
fe2831f
to
b0bb725
Compare
|
@sjahr I think this can be merged now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the following functionalities and related code from
ServoCalcsas they will be made obsolete by better support in IK solver through cost functions.Checklist