Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make loggers static or move into anonymous namespace #2184

Merged
merged 5 commits into from
May 19, 2023

Conversation

sjahr
Copy link
Contributor

@sjahr sjahr commented May 18, 2023

Description

Small cleanup for const Loggers

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (9952bdd) 50.52% compared to head (be9a71f) 50.52%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2184   +/-   ##
=======================================
  Coverage   50.52%   50.52%           
=======================================
  Files         387      387           
  Lines       31719    31719           
=======================================
  Hits        16024    16024           
  Misses      15695    15695           
Impacted Files Coverage Δ
...ics_plugin_loader/src/kinematics_plugin_loader.cpp 78.69% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sjahr sjahr merged commit 895ecac into moveit:main May 19, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants