Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that planner id is set #2202

Merged
merged 1 commit into from
May 24, 2023

Conversation

sjahr
Copy link
Contributor

@sjahr sjahr commented May 24, 2023

Description

The planner id in the motion plan response does not seem to be set by our planner plugins (I tested stomp and OMPL). This fixes it plugin agnostic without overwriting whatever the plugin sets.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@sjahr sjahr changed the title Ensure that planning pipeline id is set Ensure that planner id is set May 24, 2023
@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (052c217) 50.57% compared to head (de07882) 50.56%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2202      +/-   ##
==========================================
- Coverage   50.57%   50.56%   -0.00%     
==========================================
  Files         387      387              
  Lines       31740    31740              
==========================================
- Hits        16048    16045       -3     
- Misses      15692    15695       +3     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sjahr sjahr merged commit 0651e8a into moveit:main May 24, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants