Warn if optimization objective does not match expected values #2213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #2213 +/- ##
==========================================
- Coverage 50.52% 50.52% -0.00%
==========================================
Files 386 386
Lines 31735 31736 +1
==========================================
Hits 16030 16030
- Misses 15705 15706 +1
☔ View full report in Codecov by Sentry. |
sjahr
reviewed
Jun 1, 2023
moveit_planners/ompl/ompl_interface/src/model_based_planning_context.cpp
Outdated
Show resolved
Hide resolved
…ontext.cpp Co-authored-by: Sebastian Jahr <sebastian.jahr@tuta.io>
sjahr
approved these changes
Jun 1, 2023
henningkayser
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if you specify an optimization objective that does not match any of the expected values, the path length optimization objective will be used without warning the user. This can lead to unexpected behaviour if you have mistyped the optimization objective name. This PR adds a warning for this case.