Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress redundant error message in CSM #2222

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

henningkayser
Copy link
Member

The CSM would spam the log if /joint_states messages includes unkonwn joints. RobotModel::hasJointModel() allows for verifying joint names in a safe way without the error message.

The CSM would spam the log if /joint_states messages
includes unkonwn joints. RobotModel::hasJointModel()
allows for verifying joint names in a safe way without
the error message.
@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (b98bb6b) 50.53% compared to head (2df30f9) 50.51%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2222      +/-   ##
==========================================
- Coverage   50.53%   50.51%   -0.01%     
==========================================
  Files         386      386              
  Lines       31736    31736              
==========================================
- Hits        16034    16028       -6     
- Misses      15702    15708       +6     
Impacted Files Coverage Δ
...anning_scene_monitor/src/current_state_monitor.cpp 74.32% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@henningkayser henningkayser merged commit dfd53ab into moveit:main Jun 5, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants