Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set response planner id in planner plugins and warn if it is not set #2236

Merged
merged 3 commits into from
Jun 15, 2023

Conversation

sjahr
Copy link
Contributor

@sjahr sjahr commented Jun 12, 2023

Description

Follow up to #2202: Explicitly set the planner_id in all the available planner plugins + warn if we're making assumptions about the ID because the planner plugin does not handle it correctly.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@sjahr sjahr requested a review from henningkayser June 12, 2023 13:50
@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (8e48329) 50.50% compared to head (4a2062e) 50.51%.

❗ Current head 4a2062e differs from pull request most recent head 049b031. Consider uploading reports for the commit 049b031 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2236      +/-   ##
==========================================
+ Coverage   50.50%   50.51%   +0.02%     
==========================================
  Files         386      386              
  Lines       31730    31731       +1     
==========================================
+ Hits        16022    16026       +4     
+ Misses      15708    15705       -3     
Impacted Files Coverage Δ
...strial_motion_planner/src/trajectory_generator.cpp 96.76% <100.00%> (+0.02%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sjahr sjahr enabled auto-merge (squash) June 15, 2023 14:43
@sjahr sjahr merged commit dc1e204 into moveit:main Jun 15, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants