Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix: no transparency in collision scenes on rviz #2242

Merged
merged 3 commits into from
Jun 26, 2023
Merged

bug fix: no transparency in collision scenes on rviz #2242

merged 3 commits into from
Jun 26, 2023

Conversation

samialperen
Copy link
Contributor

@samialperen samialperen commented Jun 19, 2023

Description

On ROS humble and rviz2, I realized that collision scenes are not transparent even if their alpha value is not 1.0
This MR fixes this bug.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (636b988) 50.50% compared to head (d366a61) 50.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2242      +/-   ##
==========================================
- Coverage   50.50%   50.50%   -0.00%     
==========================================
  Files         386      386              
  Lines       31731    31732       +1     
==========================================
  Hits        16022    16022              
- Misses      15709    15710       +1     
Impacted Files Coverage Δ
..._plugin_render_tools/src/planning_scene_render.cpp 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@samialperen
Copy link
Contributor Author

@henningkayser let me know if you need more information from my side to merge this change.

@JafarAbdi JafarAbdi merged commit 31bcfef into moveit:main Jun 26, 2023
8 checks passed
@dhood
Copy link

dhood commented May 23, 2024

@JafarAbdi would you be willing to backport this to humble, please?

@JafarAbdi JafarAbdi added the backport-humble Mergify label that triggers a PR backport to Humble label May 23, 2024
@samialperen
Copy link
Contributor Author

@JafarAbdi I do not see this being backported to humble yet. https://github.com/moveit/moveit2/blob/humble/moveit_ros/visualization/rviz_plugin_render_tools/src/planning_scene_render.cpp#L112

When do you think it would be possible? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble Mergify label that triggers a PR backport to Humble
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants