New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add getJacobian tests #2375
Add getJacobian tests #2375
Conversation
899da1b
to
74400da
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #2375 +/- ##
==========================================
+ Coverage 50.74% 50.80% +0.07%
==========================================
Files 386 386
Lines 31970 31973 +3
==========================================
+ Hits 16219 16241 +22
+ Misses 15751 15732 -19 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for these test cases. Implementation looks good to me, there are still some open questions from my side. Also, how confident can we be about the angle offset 1e-04
given the fairly small delta and what is an expected tolerance?
clang-tidy has some complaints about variable naming https://github.com/ros-planning/moveit2/actions/runs/6233581824/job/16919090852?pr=2375#step:12:9507 |
74400da
to
342aea0
Compare
Not sure what's a good way to put bounds on the expected offset, but 1e-04 is small enough I think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just a couple of more suggestions to sprinkle more const
over the code (I hope all of them work and I did not miss required mutability). But not blocking the merge
Description
This change adds some basic tests for the RobotState
getJacobian
method, as a first step towards #2345. The tests cover the different types of joints (fixed, revolute, planar, prismatic) with a simple 4DOF mock robot. It also cleans up some unused code and old-style literal strings.Checklist